Open
Conversation
aschokking
approved these changes
Apr 10, 2026
stephenjust
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
This should help with further shots where we don't need as much of an offset so that we can tune shooting at closer distances.
Asana task URL:
Whats changing?
Ability to add a slope to the offset. If slope is 0 which is what it's defaulting to now it should still have a constant offset.
Basically
y = mx + bwhere b is what we have before so when m = 0 then it's the same formula.Confirmed that m = 0 in simulator still works the same, and with m = -0.15.
Questions/notes for reviewers
How this was tested